8373208: Make Atomic class template constant initializable #28711
Conversation
|
👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into |
|
@kimbarrett This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 21 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@kimbarrett The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
stefank
left a comment
stefank
left a comment
There was a problem hiding this comment.
On the surface, this looks fine to me.
dholmes-ora
left a comment
dholmes-ora
left a comment
There was a problem hiding this comment.
On the surface, this looks fine to me.
+1
3 participants
Please review this change to Atomic to meet the requirements for constant
initialization in cases where the value type provides the requisite support.
This ensures that in such cases dynamic initialization won't even be
considered a possibility when initialized with constant arguments.
Testing: mach5 tier1
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28711/head:pull/28711$ git checkout pull/28711Update a local copy of the PR:
$ git checkout pull/28711$ git pull https://git.openjdk.org/jdk.git pull/28711/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28711View PR using the GUI difftool:
$ git pr show -t 28711Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28711.diff
Using Webrev
Link to Webrev Comment